Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Multiplex fieldmap estimation outputs into a single outputnode #149

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

oesteban
Copy link
Member

Allows for an interface similar to that of sMRIPrep, which enables using
KeySelect nodes to find the appropriate connections downstream.

Required-by: nipreps/dmriprep#140.
Resolves: #147.

Allows for an interface similar to that of *sMRIPrep*, which enables using
``KeySelect`` nodes to find the appropriate connections downstream.

Required-by: nipreps/dmriprep#140.
Resolves: nipreps#147.
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #149 (afd4a00) into master (4d02005) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   94.36%   94.60%   +0.23%     
==========================================
  Files          19       19              
  Lines        1065     1075      +10     
  Branches      140      143       +3     
==========================================
+ Hits         1005     1017      +12     
+ Misses         33       32       -1     
+ Partials       27       26       -1     
Flag Coverage Δ
travis 80.07% <0.00%> (?)
unittests 94.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/workflows/base.py 100.00% <100.00%> (ø)
sdcflows/utils/bimap.py 100.00% <0.00%> (ø)
sdcflows/fieldmaps.py 85.71% <0.00%> (+0.28%) ⬆️
sdcflows/interfaces/bspline.py 96.70% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d02005...afd4a00. Read the comment docs.

@oesteban oesteban merged commit 17aa3a4 into nipreps:master Dec 11, 2020
@oesteban oesteban deleted the fix/issue-147 branch December 11, 2020 10:40
oesteban added a commit that referenced this pull request Dec 24, 2020
2.0.0rc4

* FIX: Convert SEI fieldmaps given in rad/s into Hz (#127)
* FIX: Limit ``3dQwarp`` to maximum 4 CPUs for stability reasons (#128)
* ENH: Generate a simple mask after correction (#161)
* ENH: Increase unit-tests coverage of ``sdcflows.fieldmaps`` (#159)
* ENH: Optimize tensor-product B-Spline kernel evaluation (#157)
* ENH: Add a memory check to dynamically limit interpolation blocksize (#156)
* ENH: Massage TOPUP's fieldcoeff files to be compatible with ours (#154)
* ENH: Add a simplistic EPI masking algorithm (#152)
* ENH: Utility that returns the ``B0FieldSource`` of a given potential EPI target (#151)
* ENH: Write ``fmapid-`` entity in Derivatives (#150)
* ENH: Multiplex fieldmap estimation outputs into a single ``outputnode`` (#149)
* ENH: Putting the new API together on a base workflow (#143)
* ENH: Autogenerate ``B0FieldIdentifiers`` from ``IntendedFor`` (#142)
* ENH: Finalizing the API overhaul (#132)
* ENH: Keep a registry of already-used identifiers (and auto-generate new) (#130)
* ENH: New objects for better representation of fieldmap estimation (#114)
* ENH: Show FieldmapReportlet oriented aligned with cardinal axes (#120)
* ENH: New estimation API (featuring a TOPUP implementation!) (#115)
* DOC: Minor improvements to the literate workflows descriptions. (#162)
* DOC: Fix typo in docstring (#155)
* DOC: Enable NiPype's sphinx-extension to better render Interfaces (#131)
* MAINT: Drop Python 3.6 (#160)
* MAINT: Enable Git-archive protocol with setuptools-scm-archive (#153)
* MAINT: Migrate TravisCI -> GH Actions (completion) (#138)
* MAINT: Migrate TravisCI -> GH Actions (#137)
* MAINT: Minimal unit test and refactor of pepolar workflow node (#133)
* MAINT: Collect code coverage from tests on Circle (#122)
* MAINT: Test minimum dependencies with TravisCI (#96)
* MAINT: Add FLIRT config files to prepare for TOPUP integration (#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base workflow: generate output fields as synchronized lists of elements
1 participant