Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: The calculated displacements field not exposed by unwarp workflow #224

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Aug 6, 2021

This PR addresses the SDCFlows' side (#219) of the problem holding up nipreps/fmriprep#2392.

This PR addresses the SDCFlows' side of the problem holding up
nipreps/fmriprep#2392.

Resolves: #219.
@oesteban oesteban added this to the 2.1.0 milestone Aug 6, 2021
@oesteban oesteban requested a review from mgxd August 6, 2021 15:26
@codecov-commenter
Copy link

Codecov Report

Merging #224 (4385b9c) into master (794f036) will decrease coverage by 3.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   97.08%   93.56%   -3.53%     
==========================================
  Files          24       24              
  Lines        1647     1647              
  Branches      191      191              
==========================================
- Hits         1599     1541      -58     
- Misses         25       81      +56     
- Partials       23       25       +2     
Flag Coverage Δ
travis 88.76% <ø> (ø)
unittests 93.42% <ø> (-3.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/workflows/apply/correction.py 100.00% <ø> (ø)
sdcflows/interfaces/brainmask.py 56.25% <0.00%> (-43.75%) ⬇️
sdcflows/interfaces/utils.py 80.92% <0.00%> (-17.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794f036...4385b9c. Read the comment docs.

@oesteban oesteban merged commit e6d33e6 into master Aug 6, 2021
@oesteban oesteban deleted the fix/dispfield-issue-219 branch August 6, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants