Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use it for stable releases? #44

Open
zimbatm opened this issue Jan 10, 2023 · 4 comments
Open

Also use it for stable releases? #44

zimbatm opened this issue Jan 10, 2023 · 4 comments

Comments

@zimbatm
Copy link
Member

zimbatm commented Jan 10, 2023

What do you think of expanding the scope to stable releases as well?

This project is so good, it's better than the official stable releases.

@lilyinstarlight
Copy link
Member

That is an interesting idea!

While I will admit the release pages and stuff for this project are pretty nice, I think doing it for stable releases would probably best be contributed to upstream to NixOS/nix. That way they can have fancy release pages and ghcr images in an immediately discoverable place for new users (and I could redo the logic to be less jank since it would depend less on scraping Hydra evals with a timer and comparing build results)

If you think they'll be receptive to a release page generator/ghcr uploader in NixOS/nix, I can look at working on porting something similar to the CI stuff they have there and open a draft PR for feedback

@zimbatm
Copy link
Member Author

zimbatm commented Jan 11, 2023

There might be some resistance to the ruby script but in principle, I guess it should be fine. Once they see the result, I think they will be happy.

If you are interested, I can also give you access to the nix-community/nix repo to try things out there.

@lilyinstarlight
Copy link
Member

There might be some resistance to the ruby script but in principle, I guess it should be fine. Once they see the result, I think they will be happy.

If I'm being honest, I would not redo it in Ruby (I'm still not very strong in the language and I'd go for something that has a wider developer-base). Most of the Ruby script is for scraping Hydra anyway, which we'll need far less of now so it shouldn't take much to just get rid of it

If you are interested, I can also give you access to the nix-community/nix repo to try things out there.

Ooh that could be helpful! Especially to show upstream what the end result would look like. What is the etiquette for that repo, just don't trample on others' branches? I'm assuming if you're offering it, I can make test tags and releases to experiment

@zimbatm
Copy link
Member Author

zimbatm commented Jan 11, 2023

I think nobody is using it right now so you're welcome to trash it over :)

@lilyinstarlight lilyinstarlight removed their assignment Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants