nixos/proxmox-lxc: fix getty start and nixos-rebuild #328682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise there is no getty on tty1 in Proxmox.
Same is being done in lxc-container module.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
illustris
approved these changes
Jul 20, 2024
|
I'm going to backport all fixes since 24.05 including this PR to 24.05. |
1 task
|
Successfully created backport PR for |
|
I see I was CC'ed on this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Before this PR, the console via /dev/console would work but no getty was being started on /dev/tty1 which is the default on Proxmox for new LXC containers.
Furthermore, registering the store paths is important for garbage collection if the store is being changed and the default system profile is need to make nixos-rebuild work. Otherwise switching to a new configuration fails with:
'/nix/store/la82b6h2yvrjm5sha9j5kmqks9p8sk5c-system-path/bin/busctl --json=short call org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager ListUnitsByPatterns asas 0 0' exited with value 1 at /nix/store/9r6wrz196p8v5kap6mgqr1i95is47nay-nixos-system-unnamed-24.05.83bb0d3-dirty/bin/switch-to-configuration line 145.Fixes nix-community/nixos-generators#319.
cc @smacz42 @hogcycle
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.