add language injection queries #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrdxp
force-pushed
the
injections
branch
3 times, most recently
from
901c904 to
e43d215
Compare
|
Very nice -- thanks! |
theHamsta
pushed a commit
to nvim-treesitter/nvim-treesitter
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #13
Only tested in helix-editor/helix#3594 atm, but the queries should be generic enough to work everywhere.
There is an issue with bash injection where a regex ofsolved with/".*/isn't detected by bash's tree-sitter just before a${interpolation.This causes the quoting to become unbalanced, since it doesn't detect the opening quote, it reads the rest of the string as a qouted bash string incorrectly. I haven't quite gotten to the bottom of it, but I'm fairly confident its an issue in tree-sitter-bash, since this doesn't happen in python or other language injections I tried.
injection.combined.Only outstanding issue is #32, which is solved by #33