Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forkpty() should probably be unsafe #1388

Closed
tavianator opened this issue Feb 16, 2021 · 1 comment · Fixed by #1390
Closed

forkpty() should probably be unsafe #1388

tavianator opened this issue Feb 16, 2021 · 1 comment · Fixed by #1390

Comments

@tavianator
Copy link
Contributor

fork() is unsafe (for good reason; you're not allowed to do much in the child if the parent was multithreaded). OTOH, forkpty() is not unsafe even though the same reasoning should apply.
@asomers
Copy link
Member

asomers commented Feb 20, 2021

Yep, you're right. Care to submit a PR to fix it?

@tavianator tavianator mentioned this issue Feb 20, 2021
Merged
@bors bors bot closed this as completed in 7704f5d Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pty: Make forkpty() unsafe
2 participants
@asomers @tavianator