-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo-semver-checks
to automate checking for breaking changes.
#2145
Comments
This is a nice tool! Just gave a brief look at its doc, if I understand correctly, after integrating it to our CI, a PR would fail the test if the changes made in this PR have semver violations. What if semver violation is allowed, say we are going to bump our major version in the next release |
It would be if the PR has semver violations relative to the last release on crates.io.
You would bump the version in the 1st commit since the last release that introduces a breaking change. |
This would have an unintended consequence of making it more difficult for downstream crates to test new Nix changes. Right now, Nix never bumps its version number until a release. That means that a downstream crate can use a IMHO the benefit of cargo-semver-checks is not worth the cost. |
That said, this tool looks like it would be worthwhile to use in the release procedure, just not in CI. |
Add
cargo-semver-checks
to automate checking for breaking changes.This may allow removing:
from the PR template, here: https://github.com/nix-rust/nix/blob/master/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L7
The text was updated successfully, but these errors were encountered: