Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV 1.77.0 TODO #2389

Open
asomers opened this issue Apr 28, 2024 · 1 comment
Open

MSRV 1.77.0 TODO #2389

asomers opened this issue Apr 28, 2024 · 1 comment

Comments

@asomers
Copy link
Member

asomers commented Apr 28, 2024

Whenever we raise the MSRV to 1.77.0 for any reason, we should
[ ] Replace the memoffset::offset_of! macro with the builtin macro of the same name (https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#offset_of)
[ ] Use native CStr literals instead of CString::new

@SteveLauC
Copy link
Member

  • for the following code snippet in build.rs, use cargo:: rather than cargo: in build.rs (new syntax introduced in 1.77)
    // Below are Nix's custom cfg values that we need to let the compiler know
    println!("cargo:rustc-check-cfg=cfg(apple_targets)");
    println!("cargo:rustc-check-cfg=cfg(bsd)");
    println!("cargo:rustc-check-cfg=cfg(bsd_without_apple)");
    println!("cargo:rustc-check-cfg=cfg(linux_android)");
    println!("cargo:rustc-check-cfg=cfg(freebsdlike)");
    println!("cargo:rustc-check-cfg=cfg(netbsdlike)");
    println!("cargo:rustc-check-cfg=cfg(solarish)");
    println!("cargo:rustc-check-cfg=cfg(fbsd14)");
    println!("cargo:rustc-check-cfg=cfg(qemu)");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants