Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test suite reference outputs #229

Open
jchsublet opened this issue Feb 3, 2022 · 1 comment
Open

Regression test suite reference outputs #229

jchsublet opened this issue Feb 3, 2022 · 1 comment

Comments

@jchsublet
Copy link

Traditionally NJOY87, NJOY99, NJOY12 have always been supported on multiple OS & Fortran compiler. If the free Linux as OS and GNU as Fortran certainly took over one must also recognise that the Intel Ifort compiler played an important role. The quality and thoroughness of the regression test suite of NJOY2016 makes it compiler specific. NJOY2016.65 when compiled with ifort version 19 and above delivers the same physics as its GNU counterpart but 25% of the test fail on a too strict numerical precision criteria imposed when compared with GNU Fortran reference output. The opposite would also be true. It would make sense in my view for the regression test suite reference outputs to be compiler specific and/or the numerical precision relaxed. Historically, Bob always relied on 64-bit SUN then Intel compilers to program NJOY capabilities.

Ifort_make_test.txt
.

@whaeck
Copy link
Member

whaeck commented Oct 5, 2022

arm64 architecture using gcc11.3 (which does not have the ERRORR compiler error issue for some reason) also fail on multiple tests - due to precision settings. I got a new laptop at work and it is an M1 (i.e. arm64 architecture).

I'll play around with the precision settings in the comparisons to see if I can alleviate the issue a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants