Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 10 support #1093

Closed
zzmao opened this issue Oct 17, 2020 · 2 comments
Closed

Electron 10 support #1093

zzmao opened this issue Oct 17, 2020 · 2 comments

Comments

@zzmao
Copy link

zzmao commented Oct 17, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Chromium in Electron 9 are lack of some wasm support.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Electron 10

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@nklayman
Copy link
Owner

You can upgrade to Electron 10 manually and it should work fine. The reason I haven't added it to the installation prompts is because Spectron (testing library for Electron) is broken with Electron v10. See this issue for more details: electron-userland/spectron#720. Once that issue is fixed and testing will work then I will add it as an option for the installer.

@zzmao
Copy link
Author

zzmao commented Oct 18, 2020

@nklayman thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants