You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As you can see in the comment section, this file is part of the official Go code (before 1.17). Upgrading to the latest Go internal version (filippo.io/edwards25519) should be good idea.
I saw it, assumed it was copied in early dev of nkn/ancestor-project, thought "it cannot be the same version today" and naturally aborted refactoring (I aborted ongoing work, without code-level result)
the file
edwards25519.go
is from 2013:nkn/crypto/ed25519/edwards25519/edwards25519.go
Lines 1 to 2252 in aa832aa
It contains a high amount of duplication, but is very difficult to reduce.
Suggestion
Consider switching to a more modern version:
The project https://github.com/FiloSottile/edwards25519 is and option, and it mentions several other options, like using the version include in go:
(see the commit comments for more reasons to update to a newer version)
https://go-review.googlesource.com/c/go/+/276272
Suggested Process
The text was updated successfully, but these errors were encountered: