Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single OBSID Selection not resolving #20

Closed
nkphysics opened this issue Aug 29, 2022 · 5 comments
Closed

Single OBSID Selection not resolving #20

nkphysics opened this issue Aug 29, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@nkphysics
Copy link
Owner

When entering a single OBSID into the autonicer prompt it isn't resolving with the HEASARC query table output.
Example 3013010105 will give a OBSID not found message, while selecting cycle 3 will que up the 3013010105 OBSID

@nkphysics nkphysics added the bug Something isn't working label Aug 29, 2022
@nkphysics nkphysics self-assigned this Aug 29, 2022
@nkphysics
Copy link
Owner Author

Initial investigation show a pd.Series with no values coming back in line 129 of autonicer/autonicer.py.
Most likely an error with a new version of pandas

@nkphysics
Copy link
Owner Author

Resolves perfectly fine for src ="crab pulsar" pandas v1.2.5
Broken with src=

  • "crab"
  • "PSR_B0531+21"
  • "PSR B0531+21"

@nkphysics
Copy link
Owner Author

Is still being queued up with the cycle 3 command for all the above src queries, still indicating an issue with pandas

@nkphysics
Copy link
Owner Author

Tested issue out with src=SAX J1808.4-3658 and am duplicating issue.
Additionally reverted back to pandas v1.2.4 the original pandas version used for development so this is not a pandas version issue.

@nkphysics nkphysics mentioned this issue Aug 29, 2022
@nkphysics
Copy link
Owner Author

This issue has been fixed with the release of v1.1.3.
The fix for this issue was in line 91 of AutoNICER.callnicer() where we replace any spaces in the OBSID.
See pull requests #21 and #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant