-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple build failed with json/single_include/nlohmann/json.hpp:4384:57: 'path' is unavailable #3097
Comments
I think that's because our deployment target is 10.11 which doesn't introduce "std::filesystem::path" |
Seems to be related to #3090. |
I have the same problem. My macOS deployment target is 10.12 so std::filesystem is unavailable. |
And also the iOS version should be >= 13.0. |
Thanks for the input! I will see to add the preprocessor macros. What would be the macro to test the iOS version? |
For ios, it should be |
It would be better to see if the feature test macros that are in PR now pick it up properly. |
If I understood the documentation correctly, then on macOS, the headers may be there, but the needed library is not present on earlier versions. In any case, it would be great to add an example for such a macOS/iOS build to the CI. @tongyuze can you provide an example? |
Sigh. |
Another idea is to make std::filesystem support optional with something like |
PR #3101 does this: if you define |
* ⚗️ add C++17 copies of the test binaries * ⚗️ use proper header for filesystem * 🚨 fix warnings * ⚗️ do not use too old compilers with C++17 * ✅ add test * 🔨 add more constraints #3097 * ⚗️ use fix from #3101 (comment) * ⚗️ use fix from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90050 * 👷 use published CI image
Fixed with #3090. |
What is the issue you have?
I just updated the json.hpp from version 3.9.1 to 3.10.4. And the newest version failed the Mac/iOS build with the error:
"json/single_include/nlohmann/json.hpp:4384:57: 'path' is unavailable"
This happened during compilation.
Please describe the steps to reproduce the issue.
Can you provide a small but working code example?
What is the expected behavior?
Build should succeed.
And what is the actual behavior instead?
Build failed with the above error.
Which compiler and operating system are you using?
Which version of the library did you use?
If you experience a compilation error: can you compile and run the unit tests?
The text was updated successfully, but these errors were encountered: