-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for binary values #2099
Conversation
@OmnipotentEntity Could you please have a look? Maybe I broke something along the way. I am still not 100% sure whether the internal binary type fits as it is right now, but at least now there is better coverage to test some things. |
I distinctly remember typing up a response to this thread yesterday. I guess I forgot to actually click comment. Whoops. I clearly didn't understand SAX on my first time through, and I forgot to adjust it as I learned exactly what it was supposed to do, whoops. Good catch on the binary comparison bug, that one is actually somewhat funny. I don't quite understand the binary constructor fix, but what I don't understand is why I wrote that code in the first place. I was probably cribbing off of the array code, but that's entirely not necessary for a single valued function. Tests look good to me. New features are smart additions. |
This PR adds tests for the binary values introduced in #1662 and fixes some subtle bugs along the way.
Closes #2082.