Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change argument name "subtype" in byte_container_with_subtype #2444

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Change argument name "subtype" in byte_container_with_subtype #2444

merged 2 commits into from
Dec 11, 2020

Conversation

linev
Copy link
Contributor

@linev linev commented Oct 23, 2020

Fix warnings on gcc 4.8.5: declaration of ‘subtype’ shadows a member of 'this'

@linev
Change argument name "subtype" in byte_container_with_subtype
71cb7d1 
Fix warnings on older g++ 4.8

declaration of ‘subtype’ shadows a member of 'this'
@linev linev requested a review from nlohmann as a code owner October 23, 2020 11:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 71cb7d1 on linev:fix_gcc48_warn into fd7a9f6 on nlohmann:develop.

@linev linev mentioned this pull request Oct 23, 2020
Merged
@linev linev requested a review from nlohmann December 11, 2020 12:44
nlohmann
nlohmann approved these changes Dec 11, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Dec 11, 2020
@nlohmann nlohmann added this to the Release 3.9.2 milestone Dec 11, 2020
@nlohmann nlohmann merged commit 5026acd into nlohmann:develop Dec 11, 2020
@nlohmann
Copy link
Owner

Thanks!

@linev linev deleted the fix_gcc48_warn branch December 11, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@linev @coveralls @nlohmann