Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add value_type detection to distinguish string types #3604

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Re-add value_type detection to distinguish string types #3604

merged 2 commits into from
Jul 28, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Re-add the detection of a value_type member to the is_constructible_string_type type trait.

Fixes #3602.

@falbrechtskirchinger falbrechtskirchinger marked this pull request as draft July 23, 2022 20:30
@coveralls
Copy link

coveralls commented Jul 23, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 307b828 on falbrechtskirchinger:stringtype-detection into 2d48a4d on nlohmann:develop.

@falbrechtskirchinger falbrechtskirchinger changed the title Re-add value_type detection to is_constructible_string_type trait Re-add value_type detection to distinguish string types Jul 24, 2022
@falbrechtskirchinger falbrechtskirchinger marked this pull request as ready for review July 24, 2022 05:47
@falbrechtskirchinger falbrechtskirchinger marked this pull request as draft July 27, 2022 05:33
@falbrechtskirchinger
Copy link
Contributor Author

falbrechtskirchinger commented Jul 27, 2022 •
edited
Loading

Not too happy with this band-aid; will try a different approach.

Edit: Nevermind. value_type is required by the library. I'll keep working on a better type trait for string types, but don't want to rush it.
@gregmarr raised concerns that this might be a breaking change. string_t::value_type is used in a few places and string types without a value_type member wouldn't have compiled in 3.10.4 and 3.10.5 either. To be 100% sure, I'd have to grep the release headers for string_t::value_type.

@falbrechtskirchinger falbrechtskirchinger marked this pull request as ready for review July 27, 2022 06:52
nlohmann
nlohmann approved these changes Jul 28, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 28, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 28, 2022
@nlohmann nlohmann merged commit a87c188 into nlohmann:develop Jul 28, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the stringtype-detection branch July 28, 2022 20:07
This was referenced Jul 29, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

xwidgets doesn't compile with version >3.10.3
3 participants
@falbrechtskirchinger @coveralls @nlohmann