Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use swap() by ADL #3609

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Use swap() by ADL #3609

merged 3 commits into from
Jul 28, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Bring std::swap into scope and call swap() to allow for argument-dependent lookup when using non-std containers.

gregmarr
gregmarr approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@gregmarr gregmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion on related error messages, could definitely be a separate PR.

@coveralls
Copy link

coveralls commented Jul 25, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1b0abfc on falbrechtskirchinger:adl-swap into 2d48a4d on nlohmann:develop.

nlohmann
nlohmann approved these changes Jul 28, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 28, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 28, 2022
@nlohmann nlohmann merged commit a714381 into nlohmann:develop Jul 28, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the adl-swap branch July 28, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: ⚡ improvement
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@falbrechtskirchinger @coveralls @nlohmann @gregmarr