Deprecate json_pointer/string_t comparisons #3684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3664 restored comparing
json_pointer
with strings but removednoexcept
. This is due to no longer comparing by converting thejson_pointer
to string, but by converting the string to ajson_pointer
. Doing so is more accurate (*) as we no longer allow comparing with strings that aren't valid JSON pointers. The creation of thejson_pointer
temporary is hidden from the user. For that reason I suggest deprecating the string overloads to make users aware of the implications (exceptions, allocation of ajson_pointer
).* The accuracy problem is of greater concern for the remaining relational operators, e.g., imagine comparing a
json_pointer
and the string/foo~
for less-/greater-than.