Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aimed at the fixing compilation error https://github.com/nlohmann/json/issues/4197. It was a school project, asking me to make contributions. Sorry for the inconvenience I made. #4233

Closed
wants to merge 4 commits into from

Conversation

xcyang11
Copy link

@xcyang11 xcyang11 commented Dec 4, 2023

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@xcyang11 xcyang11 requested a review from nlohmann as a code owner December 4, 2023 03:29
@xcyang11
Copy link
Author

xcyang11 commented Dec 4, 2023

Aimed at fixing compilation error #4197. It was a school project, asking me to make contributions. Sorry for the inconvenience I made. My work might be completely useless. Sorry for the trouble and inconvenience I made. Feel free to close it.

Copy link

github-actions bot commented Dec 4, 2023

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @xcyang11
Please read and follow the Contribution Guidelines.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling d820d98 on xcyang11:develop
into 9cca280 on nlohmann:develop.

@nlohmann nlohmann closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants