Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weak-vtables warning #4500

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Fix weak-vtables warning #4500

merged 7 commits into from
Nov 20, 2024

Conversation

nlohmann
Copy link
Owner

Fixes #4087

@coveralls
Copy link

coveralls commented Nov 18, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling f1dd312 on fix-weak-vtables
into 64f68dc on develop.

@gregmarr
Copy link
Contributor

I don't believe that it is worth trying to "fix" this. More details at #4087 (comment)

@nlohmann nlohmann marked this pull request as ready for review November 19, 2024 08:11
@nlohmann
Copy link
Owner Author

I forgot to also remove the previous fixes in the test cases and add a pragma.

@gregmarr
Copy link
Contributor

Do we need to worry about someone building the tests with different warning flags? I would hope that we'd be able to say "the tests are built with exactly these flags".

@nlohmann
Copy link
Owner Author

Do we need to worry about someone building the tests with different warning flags? I would hope that we'd be able to say "the tests are built with exactly these flags".

In the end, I did not suppress the warning, but could fix it by completing the rule of five.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Nov 20, 2024
@nlohmann nlohmann merged commit 378e091 into develop Nov 20, 2024
129 checks passed
@nlohmann nlohmann deleted the fix-weak-vtables branch November 20, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting a weak-vtables warning with clang on ubuntu 22.04
3 participants