-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weak-vtables warning #4500
Fix weak-vtables warning #4500
Conversation
I don't believe that it is worth trying to "fix" this. More details at #4087 (comment) |
I forgot to also remove the previous fixes in the test cases and add a pragma. |
Do we need to worry about someone building the tests with different warning flags? I would hope that we'd be able to say "the tests are built with exactly these flags". |
In the end, I did not suppress the warning, but could fix it by completing the rule of five. |
Fixes #4087