Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terrain-profile to oskari-server-extras #18

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

jampukka
Copy link
Contributor

@jampukka jampukka commented Mar 1, 2022

Goal is to make

<groupId>fi.nls.paikkatietoikkuna</groupId>
<artifactId>service-terrain-profile</artifactId>
<version>1.21.0-SNAPSHOT</version>

available as a dependency for other applications (besides Paikkatietoikkuna) by publishing it under Oskari.org repository as

<groupId>fi.nls.oskari.extras</groupId>
<artifactId>service-terrain-profile</artifactId>
<version>1.1</version>

edit: change version 1.0 -> 1.1, see #20

@ZakarFin
Copy link
Collaborator

ZakarFin commented Mar 2, 2022

Trying to compile with Maven it says:

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /C:/Omat/oskari/oskari-server-extras/service-terrain-profile/src/main/java/fi/nls/oskari/terrainprofile/dem/ScaledGrayscaleValueExtractor.java:[44,97] incompatible types: short[] cannot be converted to float[]
[ERROR] /C:/Omat/oskari/oskari-server-extras/service-terrain-profile/src/main/java/fi/nls/oskari/terrainprofile/dem/FloatAsIsValueExtractor.java:[30,77] incompatible types: bad return type in lambda expression
    void cannot be converted to float[]
[INFO] 2 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

@ZakarFin
Copy link
Collaborator

ZakarFin commented Mar 2, 2022

@jampukka
Copy link
Contributor Author

jampukka commented Mar 2, 2022

Just remembered that this actually requires oskariorg/oskari-server#813 which is not part of even 2.6.0 but upcoming 2.7.0

Co-authored-by: Sami Mäkinen <zakarfin@gmail.com>
@ZakarFin
Copy link
Collaborator

Awesome, thanks! I'll merge this now that 2.7.0 Oskari-server has been released.

@ZakarFin ZakarFin merged commit aa6eefe into nlsfi:master Mar 25, 2022
@jampukka jampukka deleted the feature/service-terrain-profile branch March 28, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants