Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: getcharid and getguildinfo base command #36

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: getcharid and getguildinfo base command #36

wants to merge 5 commits into from

Conversation

DanielHe4rt
Copy link
Contributor

@DanielHe4rt DanielHe4rt commented Dec 17, 2023 •
edited
Loading

Description

Implementing missing features for Kafra NPC.

To-do

  • cutin
  • percentheal
  • viewpoint
  • implode
  • countitem
  • delitem
  • basicskillcheck
  • getskilllv
  • getcharid
  • getguildinfo
  • savepoint
  • emotion
  • logmes

@DanielHe4rt
Copy link
Contributor Author

@nmeylan There's any easier way to test these commands on compile time?

@DanielHe4rt
Copy link
Contributor Author

image
And how about commands that isn't implemented at rAthena codebase?

image

@DanielHe4rt
Copy link
Contributor Author

Nevermind, it belongs to Hercules and not rAthena.

@nmeylan
Copy link
Owner

nmeylan commented Dec 18, 2023 •
edited
Loading

@nmeylan There's any easier way to test these commands on compile time?

You mean at build time with test? Unfortunatly i have not setup unit test for this native function handler method, but it would be nice to have. I am afraid that we add more and more feature to this function without tests, it will be harder to catch up

The vm was designed to make testing of scripts easy
https://github.com/nmeylan/rathena-script-lang-interpreter/tree/master/tests
https://github.com/nmeylan/rathena-script-lang-interpreter/blob/master/tests/native_test.rs#L21

@DanielHe4rt
Copy link
Contributor Author

Are you sure that the function "logmes" is placed in any Kafra's script? I took a look into rAthena and Hercules src's and didn't found anything related there.

Maybe it will have a specific usage that you're planning?

@nmeylan nmeylan force-pushed the master branch 2 times, most recently from c43748a to 94e61c6 Compare January 13, 2024 15:15
@nmeylan nmeylan force-pushed the master branch 10 times, most recently from 77c2c3e to cfddd39 Compare February 5, 2024 10:07
@nmeylan nmeylan force-pushed the master branch 7 times, most recently from 7443f66 to 5880688 Compare February 14, 2024 13:38
@nmeylan nmeylan force-pushed the master branch 4 times, most recently from 41cea2f to 9fc8d58 Compare March 8, 2024 14:19
@nmeylan nmeylan force-pushed the master branch 2 times, most recently from dce939c to 93c28d1 Compare March 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielHe4rt @nmeylan