Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The abbreviation for Stock Synthesis is SS3 #11

Open
kellijohnson-NOAA opened this issue Jun 6, 2024 · 5 comments
Open

The abbreviation for Stock Synthesis is SS3 #11

kellijohnson-NOAA opened this issue Jun 6, 2024 · 5 comments

Comments

@kellijohnson-NOAA
Copy link
Collaborator

Just wanted to bring to your attention that the abbreviation for Stock Synthesis is SS3 not the two letter version. We made a concerted effort inside the Stock Synthesis community to change to SS3 because the shorter acronym can be offensive in some cultures. Please let me know if you would like help changing this within the package because I am happy to open a pull request or help track down where the two-letter acronym is used.

@kellijohnson-NOAA
Copy link
Collaborator Author

@Schiano-NOAA let me know if you want help with this.

@Schiano-NOAA
Copy link
Collaborator

@kellijohnson-NOAA I am going through the package files today and making some large changes and adjustments. It would definitely be a big help to have a second set of eyes. Would you be able to give it a check later this week or next? Thanks!!

@kellijohnson-NOAA
Copy link
Collaborator Author

I might have some time on Friday but next week I can dedicate some time to whatever part you point me to.

@iantaylor-NOAA
Copy link

This issue may have been completely resolved by now, but I think a useful way to search for remaining instances of "SS" vs "SS3" would be to delete the "ss" line from WORDLIST

ss
which would then cause the spell check github action to fail with an error that points to the file and line number of any remaining instances of "SS".

@Schiano-NOAA
Copy link
Collaborator

This issue may have been completely resolved by now, but I think a useful way to search for remaining instances of "SS" vs "SS3" would be to delete the "ss" line from WORDLIST

ss

which would then cause the spell check github action to fail with an error that points to the file and line number of any remaining instances of "SS".

This is a great catch and suggestion! I will make that change so it flags any other instances, but I agree that this has been resolved. I kept it open for this exact reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants