Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors in seasonal recruitment and empirical wtatage #283

Closed
Rick-Methot-NOAA opened this issue Apr 5, 2022 · 3 comments · Fixed by #284
Closed

errors in seasonal recruitment and empirical wtatage #283

Rick-Methot-NOAA opened this issue Apr 5, 2022 · 3 comments · Fixed by #284
Assignees
Labels
biology bug Something isn't working; don't remove label after fixing change log use for issues that should appear in change log
Milestone

Comments

@Rick-Methot-NOAA
Copy link
Collaborator

Two issues were detected while working with Peter Kuriyama's anchovy model. One related to use of 2 seasons, and one related to use of empirical wtatage.
1.  recruitment in the Time_Series table is recruitment by area, not total recruitment.  They should be the same in a one area model. However, in a 2 season model with all recruits assigned to one season, a double counting occurs as the code loops seasons. The recruitment reported in this table gets accumulated for each season.
FIX by making the accumulation conditional on Settle_season. This was the case several releases ago, but got changed.
2.  Within the report.sso sequence to output biology, there were insufficient traps to prevent biology based fecundity calculations from overwriting fecundity as read from wtatage.ss. This occurred late in the output so few other items were affected by this overwriting. It was noticed when looking at SPR/YPR profile and the global MSY would also be affected. This issue may have caused when wtage storage was reconfigured in 3.30.17 or 0.18
FIX by adding appropriate conditional statements like:
if(WTage_rd==0) get_mat_fec();

@Rick-Methot-NOAA Rick-Methot-NOAA added bug Something isn't working; don't remove label after fixing biology labels Apr 5, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA self-assigned this Apr 5, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA added the in progress This is being worked on in a branch label Apr 5, 2022
@Rick-Methot-NOAA
Copy link
Collaborator Author

@k-doering-NOAA I think this fix warrants a redo of the 3.30.19 release. Sigh!

@Rick-Methot-NOAA
Copy link
Collaborator Author

@kellijohnson-NOAA I checked hake and this issue seems not to affect it, but I thought it would be affected.

@k-doering-NOAA
Copy link
Contributor

@Rick-Methot-NOAA , we can put out a "fix" version, as we have done in the past. It definitely seems important to get the fix out there!

@Rick-Methot-NOAA Rick-Methot-NOAA added resolved issue resolved, look for "needs test" label and removed in progress This is being worked on in a branch labels Apr 13, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA linked a pull request Apr 13, 2022 that will close this issue
4 tasks
@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.19 milestone Apr 13, 2022
@k-doering-NOAA k-doering-NOAA modified the milestones: 3.30.19, 3.30.20 Apr 15, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA added the change log use for issues that should appear in change log label Sep 16, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA removed the resolved issue resolved, look for "needs test" label label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
biology bug Something isn't working; don't remove label after fixing change log use for issues that should appear in change log
Projects
Status: No status
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants