Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to CATCH_AT_AGE report:40 ERA = "INIT" in November 2021 #288

Closed
kellijohnson-NOAA opened this issue Apr 11, 2022 · 6 comments · Fixed by #290
Closed

changes to CATCH_AT_AGE report:40 ERA = "INIT" in November 2021 #288

kellijohnson-NOAA opened this issue Apr 11, 2022 · 6 comments · Fixed by #290
Assignees
Labels
fishing mortality resolved issue resolved, look for "needs test" label
Milestone

Comments

@kellijohnson-NOAA
Copy link
Contributor

I was updating the executable in ss3sim and noticed changes to Report.sso between 3.30.16 and 3.30.19 in CATCH_AT_AGE for the INIT era. In 3.30.18 INIT was zero for all ages. I did not change any of the input files only the executable and all of a sudden there were real positive values for each age in CATCH_AT_AGE for the initial year. The change in the code that is causing this happened sometime between a7a1321 and cd278a5. Attached are the input files and the new versus old Report.sso. Line 4163 has the differences of interest. @Rick-Methot-NOAA I am happy to help debug here, but I thought that getting your initial insight would be helpful.
Diffbetween18v19.zip

@kellijohnson-NOAA kellijohnson-NOAA added the new request initial entry of a new request label Apr 11, 2022
@Rick-Methot-NOAA
Copy link
Collaborator

Isn't the bug the lack of output and the fix is the current code that produces that line of output?

@kellijohnson-NOAA
Copy link
Contributor Author

kellijohnson-NOAA commented Apr 11, 2022

Where the catches are now being reported in catch-at-age for equilibrium catch? Ian and I couldn't remember talking about this change while we were going over the differences in the report files but maybe it was part of #192?

@iantaylor-NOAA
Copy link
Contributor

This doesn't seem to just be adding output where it was missing before because the obs and expected INIT equilibrium catch is 0 as shown in the CATCH report:15 table. So I would think that CATCH_AT_AGE report:40 should likewise be 0 for the INIT era.

@Rick-Methot-NOAA
Copy link
Collaborator

OK. I'll take a look.

@Rick-Methot-NOAA Rick-Methot-NOAA added fishing mortality resolved issue resolved, look for "needs test" label labels Apr 12, 2022
@Rick-Methot-NOAA
Copy link
Collaborator

there was a forgotten Hrate(f,t)* in the calculation of equilibrium popdy.
fixed now.

@kellijohnson-NOAA kellijohnson-NOAA removed the new request initial entry of a new request label Apr 12, 2022
@kellijohnson-NOAA
Copy link
Contributor Author

Thanks @Rick-Methot-NOAA for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fishing mortality resolved issue resolved, look for "needs test" label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants