Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group convolution in CARN #19

Open
qingchuanhuajuan opened this issue Mar 18, 2019 · 3 comments
Open

Group convolution in CARN #19

qingchuanhuajuan opened this issue Mar 18, 2019 · 3 comments

Comments

@qingchuanhuajuan
Copy link

Hello there
You have proposed two models, CARN and CARN-M.
Figures 2 and 3 of your paper, and paragraph 3 of the paper, show that the residual block in your CARN uses residual-E. But in your code, only CARN-M uses group convolution. The residual module used by CARN is just a normal convolution rather than a group convolution. But the last paragraph of Section 4.4 of your paper mentions that the PSNR of CARN is 28.7. I don't understand this value, it is not found in Table 1. So, is your CARN model the same as described in the code?

@nmhkahn
Copy link
Owner

nmhkahn commented Mar 22, 2019

Hi.

  1. Only CARN-M uses residual-e block (group convs) as in the code.
  2. In the section 4.4, PSNR of CARN is only calculated for the ablation study so that we decrease the training steps and so on.

@qingchuanhuajuan
Copy link
Author

Thank you very much for your answer.
I have a question, the SRDensenet authors did not publish their experimental results images, are you training yourself? The results of my own training are not as good at SRDensenet. Can you share the test results of SRDensenet on the benchmark data set (4X)?

@nmhkahn
Copy link
Owner

nmhkahn commented Mar 24, 2019

As you say, since they didn't publish the result images, we only record the performance result that borrowed from their paper. For the qualitative comparison like Fig 6, we put the methods that we can get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants