Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The image size of reconstruction result from Urban100 don't match with original images. #2

Closed
qibao77 opened this issue Aug 7, 2018 · 5 comments

Comments

@qibao77
Copy link

qibao77 commented Aug 7, 2018

The original image resolution of Urban100 exceeds 1024p, but your results are less than it.

@nmhkahn
Copy link
Owner

nmhkahn commented Aug 7, 2018

Hi.
Thanks for letting us know the problem. Perhaps there was some undesirable thing happens when we did create LR image in x2 and x3 scale. So the HR resolution of x2 and x3 scale was incorrect compared to the original dataset, thus leads the different resolution of the reconstruction image.

Honestly, when we benchmark on the Urban x3 dataset, it seems weird that the PSNR score of our model was unbelievably low, but now it's quite reasonable.
Anyway, here is the new result table:

@qibao77
Copy link
Author

qibao77 commented Aug 7, 2018

Thank you for your answer. But I have another problem. The parameters of CARN or CARN-M should be different on three scale factors since you are upsampling LR images at the end of the network, but params. of CARN or CARN-M are same in your table (1592K and 412K).

@nmhkahn
Copy link
Owner

nmhkahn commented Aug 7, 2018

The reason is because the model holds all the upsample blocks even they doesn't use it. This idea also be used in MDSR to implement multi-scale learning. And we also claim that this property makes the model more efficient since we can process multiple scale data only using single model.

If you want more details, please check paragraph 4 in section 4.3 in our paper.

@qibao77
Copy link
Author

qibao77 commented Aug 7, 2018

I find it, thank you very much!

@nmhkahn nmhkahn closed this as completed Sep 27, 2018
@kk6398
Copy link

kk6398 commented Nov 29, 2020

Hello,dear owner:
I have two questions that confuse me a lot , it still puzzles me after I have searched much on the internet.
for 1) ,I have read the answer above , I still don't know the exact reason why the number of parameters is 1592K and 412K constantly. I run the program on my computer, when I change the scale for X2, X3, X4(group = 1) , the parameters are 964187,1148827, 1111899, respectively. I only get the parameters----1592K when scale = 0.
for 2),I puzzle that how to get or calculate the size of model----Mutil-Adds. It seems like that it don't symbolize in the program.

    Waiting for your answer sincerely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants