From 4a8b3a40eac5c671dff53a0ca1948a75ddf60ae2 Mon Sep 17 00:00:00 2001 From: Nathan Moinvaziri Date: Fri, 4 Aug 2023 11:34:23 -0700 Subject: [PATCH 1/3] Fixed unused variables in proxy_resolver_mac_get_proxies_for_url --- resolver_mac.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/resolver_mac.c b/resolver_mac.c index 1512ff3..2ed2513 100644 --- a/resolver_mac.c +++ b/resolver_mac.c @@ -116,8 +116,6 @@ bool proxy_resolver_mac_get_proxies_for_url(void *ctx, const char *url) { CFURLRef target_url_ref = NULL; CFURLRef url_ref = NULL; char *auto_config_url = NULL; - char *proxy = NULL; - char *bypass_list = NULL; bool is_ok = false; if (!proxy_resolver || !url) From 223c4956f3cc887964f759512459b69a80caa82c Mon Sep 17 00:00:00 2001 From: Nathan Moinvaziri Date: Fri, 4 Aug 2023 11:34:42 -0700 Subject: [PATCH 2/3] Fixed error not used in print statement. --- resolver_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resolver_mac.c b/resolver_mac.c index 2ed2513..9bbbd30 100644 --- a/resolver_mac.c +++ b/resolver_mac.c @@ -124,7 +124,7 @@ bool proxy_resolver_mac_get_proxies_for_url(void *ctx, const char *url) { auto_config_url = proxy_config_get_auto_config_url(); if (!auto_config_url) { proxy_resolver->error = EINVAL; - LOG_ERROR("Auto configuration url not specified", proxy_resolver->error); + LOG_ERROR("Auto configuration url not specified"); goto mac_done; } From cf5d6db573ce7720f8d6317fa1f44c613f8ab964 Mon Sep 17 00:00:00 2001 From: Nathan Moinvaziri Date: Fri, 4 Aug 2023 11:37:49 -0700 Subject: [PATCH 3/3] Fixed printf type warning on macOS. --- wpad_dhcp_posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpad_dhcp_posix.c b/wpad_dhcp_posix.c index 8139a20..82431d0 100644 --- a/wpad_dhcp_posix.c +++ b/wpad_dhcp_posix.c @@ -179,7 +179,7 @@ static bool dhcp_read_reply(SOCKET sfd, uint32_t request_xid, dhcp_msg *reply) { const ssize_t response_len = recvfrom(sfd, (char *)reply, sizeof(dhcp_msg), 0, NULL, NULL); if (response_len <= (ssize_t)(sizeof(dhcp_msg) - DHCP_OPT_MIN_LENGTH)) { - LOG_DEBUG("Unable to read DHCP reply (%d:%d)\n", response_len, socketerr); + LOG_DEBUG("Unable to read DHCP reply (%d:%d)\n", (int32_t)response_len, socketerr); return false; }