Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managed-by label of nmstate-ca secret is wrong #882

Open
RamLavi opened this issue Nov 15, 2021 · 1 comment
Open

managed-by label of nmstate-ca secret is wrong #882

RamLavi opened this issue Nov 15, 2021 · 1 comment

Comments

@RamLavi
Copy link
Collaborator

RamLavi commented Nov 15, 2021

What happened:
the managed-by label value of self deployed objects should not be inherited from CNAO/HCO CR.

$ kubectl get secret nmstate-ca -n kubevirt-hyperconverged -o custom-columns="":.metadata.labels

map[
app.kubernetes.io/component:network 
app.kubernetes.io/managed-by:hco-operator 
app.kubernetes.io/part-of:hyperconverged-cluster 
app.kubernetes.io/version:1.6.0
]

What you expected to happen:
It must be app.kubernetes.io/managed-by: kubernetes-nmstate-webhook (pretty sure it's the webhook, right?)

How to reproduce it (as minimally and precisely as possible):
deploy HCO/CNAO and take a look at the secret label.

Anything else we need to know?:
similar to issue opened on CNAO kubevirt/cluster-network-addons-operator#1051
Environment:

@oshoval
Copy link
Collaborator

oshoval commented Dec 21, 2021

Note please that are more entities such as enactments that are created by nmstate, so they need to be updated as well.
Generally speaking we need to find and fix it for all the elements that were not directly deployed by CNAO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants