-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not recognised by the parser: AO2A ... #1
Comments
I've also noticed that a few of the groups, like LightningGroup, do not seem to have any members or parsing implementation. Maybe it would be good to document a list of the incomplete portions in the readme, or add TODO comments in the code? |
Thank you, I'm definitely interested in adding more groups to the parser.
I was not aware of this one. Remarks are rarely used in my region.
This is a planned feature, WeatherBeginEndGroup is reserved for it (no parsing functionality yet).
Also planned feature, VicinityGroup is reserved it (likewise no parsing functionality yet).
Planned feature, CloudGroup has minHeight() and maxHeight() for this purpose (no functionality at the moment). Besides these, I plan to eventually add the following groups:
I would appreciate if you can advice anything else commonly used in your area but not on the list above.
These groups are added to std::variant Group to maintain backward compatibility and I plan to add parsing functionality eventually. They are included in the docs, also I think it is a good idea to mark them TODO in the code. Lightning group is reserved for LTG; WeatherBeginEndGroup for RAB, RAE, etc; VicinityGroup for TS E MOV W or CB NW, etc. |
Thank you for so rapidly adding support for AO1A/AO2A in 7e0cd17 My company (FlightAware) is currently exploring the idea of using metaf to replace our existing parsing code (https://github.com/flightaware/mdsplib) for handling data for airports around the world. When that project progresses, I may be able to provide more bug reports if I find any other differences, however I believe the lack of the currently missing functionality you mentioned above is okay for our needs. |
By 4978b02 the functionality mentioned in original post is available:
However I cannot find any information or guideline on group format If the group is modified to
Hope this helps. I would appreciate any bug reports and suggestions of functionality to be added. |
Are you interested in issues about missing parsing logic?
This METAR has a few examples of things that are not currently parsed:
Some of those unparsed elements should be something similar to the following fragment (from mdsplib):
The text was updated successfully, but these errors were encountered: