Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating input variables NetCDF file for improved testing #25

Closed
drnimbusrain opened this issue Sep 27, 2022 · 7 comments
Closed

Creating input variables NetCDF file for improved testing #25

drnimbusrain opened this issue Sep 27, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@drnimbusrain
Copy link
Member

drnimbusrain commented Sep 27, 2022

@angehung5 Do you think you can make an input gridded, NetCDF file that is identical to the current develop input_variables.txt file?

As shown in Issue #22 , we want to also add an option in canopy-app for both inputting and outputting NetCDF gridded files to improve testing and assessment of different modules.

@angehung5
Copy link
Collaborator

angehung5 commented Sep 27, 2022

@drnimbusrain Sure, I definitely can do that. Just to clarify, should netCDF4 file include 1D or 2D variables? Or you want to make it flexible?

@zmoon
Copy link
Member

zmoon commented Sep 27, 2022

I would suggest making it 2-D, since that seems more natural, but maybe we can try to design so that it would be possible to load 1-D as well

@angehung5
Copy link
Collaborator

OK, I will generate both 1D and 2D inputs for testing, we can determine this later

@drnimbusrain
Copy link
Member Author

drnimbusrain commented Sep 27, 2022

I like this plan @angehung5 and @zmoon. The canopy-app may be mainly driven by 2D surface variables, but I can imagine there are some 1D variables that could be used.

One other thing to decide is what is our NetCDF file format/convention. We should follow some standard as best as possible for both the input and optional output NetCDF (e.g., latitude, longitude, time, height, etc.) and associated variable attributes. Maybe CF convention? https://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html

@zmoon
Copy link
Member

zmoon commented Sep 27, 2022

Yeah for sure we should try to make nice output files, following CF, i.e. making sure all have long_name and units attrs, and adding standard_name when possible (i.e. when variable is in the standard name table). I also like adding description attr with more detailed description in some cases.

@angehung5
Copy link
Collaborator

yes, detailed descriptions would be helpful. I will add add them in the file.

@drnimbusrain
Copy link
Member Author

@angehung5 @zmoon Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants