Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd Table Allignment? #19

Closed
AJ213 opened this issue Mar 18, 2020 · 3 comments
Closed

Odd Table Allignment? #19

AJ213 opened this issue Mar 18, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AJ213
Copy link

AJ213 commented Mar 18, 2020

Describe the feature you'd like to request.
Despite the title is a question, the feature requested here is for the table to not have "odd" formatting. I believe the "Segment" data is left-aligned in the table (not the header, the data), while the rest of the data (e.g. the Best Segment Data) are right-aligned to the header. What also might help is a table title, but this might be unnecessary and you might have to do testing on that.

Give reasoning on why this feature is needed.
The table just looks kind of jank right now, especially if there are sub-splits involved.

Additional context
Table example
Example of the allignment

@AJ213 AJ213 added the enhancement New feature or request label Mar 18, 2020
@AJ213
Copy link
Author

AJ213 commented Mar 18, 2020

I could be mistaken though, this could be standard table alignment design. Maybe adding vertical lines might fix it appearing odd.

@noahkra
Copy link
Owner

noahkra commented Mar 18, 2020

The table is made according to Material design spec, which states text should be left aligned and numbers right aligned. No vertical lines.

I'll take a look at it to see if I can make it look better than it does currently by limiting the width of the columns.

@noahkra
Copy link
Owner

noahkra commented Mar 18, 2020

Turns out I didn't realise the headers of the right aligned numbers should also be right aligned.. Oops. Fixed.

image

@noahkra noahkra closed this as completed Mar 18, 2020
@noahkra noahkra added this to the v0.3.0 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants