Modifier prefix (like C-M-)

[Kungsgeten]

Hi! I'm trying out switching from bind-key to general in my Emacs config. I use a keyboard with QMK firmware, which basically lets the keyboard do all sort of crazy things. One thing I have is something called the "Meh key", which is a single key that simulates holding C-M-S when held down. Since I tend to forget which keys it actually simulates, I've written this in my init:

(defun meh (string)
  "Add the meh key prefix to STRING."
  (concat "C-M-S-" string))

Which I then can run like this:

(general-define-key
   (meh "f") 'projectile-next-project-buffer)

I just wondered if there's a more elegant way to do this, for instance with general-create-definer?

[noctuid]

It's been on my todo list for a while to have :prefix support this directly. You could write a macro to go through all the keys and add the prefix to them, but there's not a better alternative currently. I'll try to look into it sometime next week; feel free to ping me after that as I may forget.

[noctuid]

I'm thinking about the best syntax for this. I can't just treat `:prefix "C-M-S-" as a modifier since it could also be those letters and hyphens. I'm thinking one of these:

(general-def
  :prefix '("C-M-S-" :modifier t)
  "f" #'projectile-next-project-buffer)

(let ((general-prefix-ending-in-hypen-is-modier t))
  (general-def
    :prefix "C-M-S-"
    "f" #'projectile-next-project-buffer))

The variable could be set globally or around a general-create-definer and would treat letters followed directly by hyphens as modifiers (e.g. "-" and "-a" and "C -" would not be considered modifiers). Any preference?

[Kungsgeten]

Just made some changes to my init and checked if there had been any updates here :) From a user perspective I think something like this would be nice:

(general-create-definer meh
  :modifier "C-M-S")

Maybe prefix-command and prefix-map could be supported too (or have modifier variants).

[noctuid]

I will use this feature too, but it's not high priority for me. I think it will still be a little complicated with another keyword. I'm not planning on adding support until #497 (not anytime soon) but will accept a PR for it if anyone wants to make one.