Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async event listeners possible? #503

Closed
akosyakov opened this issue May 9, 2019 · 3 comments
Closed

async event listeners possible? #503

akosyakov opened this issue May 9, 2019 · 3 comments
Labels
Area: APIs Things related to external and internal APIs good first issue Good for newcomers and first-timer contributors Priority: Low This issue can probably be picked up by anyone looking to contribute to the project. Status: Available No one has claimed for resolving this issue. Generally applied to bugs and enhancement issues. Status: Proposal A feature request or another suggestion. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR.

Comments

@akosyakov
Copy link

akosyakov commented May 9, 2019 •
edited
Loading

Hey 👋 i want to use async code in fileBegin to make sure that full path exists with mkdirs without blocking. Is it possible?

Should req.pause before async block and req.resume after do the trick?
@GrosSacASac
Copy link
Contributor

It is not possible currently. file.path has to be modefied sync during fileBegin otherwise it has no effect

@tunnckoCore tunnckoCore added good first issue Good for newcomers and first-timer contributors Priority: Low This issue can probably be picked up by anyone looking to contribute to the project. Status: Available No one has claimed for resolving this issue. Generally applied to bugs and enhancement issues. Status: Proposal A feature request or another suggestion. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR. and removed feature request labels Apr 2, 2022
@tunnckoCore tunnckoCore mentioned this issue Apr 3, 2022
Open
@tunnckoCore tunnckoCore added the Area: APIs Things related to external and internal APIs label Apr 3, 2022
@GrosSacASac
Copy link
Contributor

May I ask why you want to make sure that full path exists with mkdirs without blocking ?
Because maybe your endgoal is already solved by a recent change in this library

@GrosSacASac
Copy link
Contributor

I believe this issue is fixed by #855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: APIs Things related to external and internal APIs good first issue Good for newcomers and first-timer contributors Priority: Low This issue can probably be picked up by anyone looking to contribute to the project. Status: Available No one has claimed for resolving this issue. Generally applied to bugs and enhancement issues. Status: Proposal A feature request or another suggestion. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @tunnckoCore @GrosSacASac