Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Github Actions for CI #53

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

MariusRumpf
Copy link
Collaborator

  • Adds a CI config for Github Actions
  • Removes Appveyor and Travis as CI
  • Cleans up badges in the readme

@ristomatti ristomatti self-assigned this Jan 25, 2023
@ristomatti
Copy link
Collaborator

This is awesome. I've yet to have time or inspiration to dig into GitHub actions. Is there a way to verify if the setup works?

README.md Show resolved Hide resolved
@ristomatti
Copy link
Collaborator

Are today's actions bringing an old project to an end, or would you perhaps be interested in joining the project? As an honorary member if nothing else? 🙂

@MariusRumpf
Copy link
Collaborator Author

It is possible to see it in action in my fork to validate the results:
https://github.com/MariusRumpf/lifx-lan-client/actions/runs/4008683675

@MariusRumpf
Copy link
Collaborator Author

I am not sure how much time I can spare, but if I find some I will try to help out. Honorary member if nothing else sounds great 🙂
Today marks the day I sunset the old project which I could not support any longer, alone.

Copy link
Collaborator

@ristomatti ristomatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ristomatti ristomatti merged commit 25617c0 into node-lifx:main Jan 25, 2023
@ristomatti
Copy link
Collaborator

I've had trouble finding time as well but I still have the incentive as most of our apartment is lit with LIFX ligs. I even bought some spares recently after spotting them for cheap on a local consumer electronics retailer, even while LIFX's EU store had all sold out.

Have you noticed LIFX brand has been sold? It's likely not good news. I have yet to see anything good come out of IoT brands getting sold. It was not at all surprising to me as the community forum has had almost zero activity for the past few years. A huge alarm bell was when the most visible and active LIFX employee left the company.

In fact I already had a bad feeling when they pushed out their, in my opinion, garbage rewrite of the mobile app. As a fan of the old simple app, I had a few things to say about the update.

While writing this, I also noticed the new owner of the brand is "reviewing our sales strategy in your region": :https://lifxshop.eu/

But now I'll end my rant and resume back to paid work 😣. Also, I've sent you an invite to join the team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants