-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relevance in later versions of NODE #62
Comments
So, found an answer to my own question. Node doesn't do socket timeouts in many versions. I use 8.9.4 and it doesn't do it there (No timeout option: https://nodejs.org/docs/latest-v8.x/api/http.html#http_new_agent_options). Version 10 does seem to have a timeout option that it passes into the socket, but apparently this does not close the socket (https://nodejs.org/api/net.html#net_socket_settimeout_timeout_callback). So using this library will indeed add that functionality to certain versions of Node. |
agentkeepalive using the same code base as http.Agent. |
Node 8.9.4 have time option in agent constructor but no documented. If the socket is timeout, will emit |
I noticed that the benchmark script in this library really just compares keep-alive to non-keepalive.
Has any benchmarking been done against the normal http.Agent or https.Agent using keepalive and the same maxSockets?
Are there any performance benefits to using this library?
The text was updated successfully, but these errors were encountered: