lightclient: fix validator set change #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setunapo
approved these changes
Aug 30, 2023
|
How do you find that problem here? |
|
This transaction is about greenfield, and find there is a bugfix about this. Usually you can dump all the opcode from bsc and erigon, and find the problem |
|
@blxdyx WDYT if it's possible to write integration tests to compare erigon EVM to bsc EVM? |
|
And how are you dumped opcodes? With debug and trace methods from the bsc node? Do you guys run it in your own infrastructure? |
|
In my dev net, and add some logs to print the opcodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue: #208
pick from: bnb-chain/bsc#1645