Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to pick a color on android #117

Closed
sleiner opened this issue Dec 16, 2016 · 9 comments
Closed

unable to pick a color on android #117

sleiner opened this issue Dec 16, 2016 · 9 comments
Labels

Comments

@sleiner
Copy link

sleiner commented Dec 16, 2016

bug

The color picker widget is showing but I can not choose a new color on the phone.
Also live updates to the phone do not work.
On Firefox/Windows and Chrome/Windows, this all works fine.

used version

  • node-red-dashboard: 2.2.0
  • node-red: 0.15.2
  • node.js: 0.10.29

reproduced on

  • Android 6.0.1 and Android 5.0.2, with both
    • Firefox 50.1.0
    • Chrome 55.0.2883.91
@hobbyquaker
Copy link
Contributor

I can reproduce this on Safari iOS too. On Safari macOS it works. (touch vs click?)

@JavierNR
Copy link

JavierNR commented Dec 16, 2016

Hello!

I can confirm this behavior with Safari under iOS v10.1.1 BTW touching at random locations seems to change the colour picker value (and also outside colourpicker zone).

nodejs v4.7.0
node-red: 0.15.2`
node-red-dashboard: 2.2.0

Sorry as I didn't had the time to test it under beta.

@dceejay
Copy link
Member

dceejay commented Dec 16, 2016

yes - ok got it... (seems to be a bug in underlying library - that has reappeared due to some change in Chrome...) - looking into it...

@elstanto
Copy link
Contributor

I think I've found a fix for the library, just waiting for them to respond 😄

@dceejay
Copy link
Member

dceejay commented Dec 17, 2016

For those willing to test ... I have pushed a built version to git-master with @Helgrind patch included - this is not the final fix (hopefully the author will update soon) - but feel free to try it
npm i node-red/node-red-dashboard
is the simple way to get it... (then refresh the browser a couple of times to flush your caches out).

@hobbyquaker
Copy link
Contributor

working fine on Safari/iOS.

@dceejay
Copy link
Member

dceejay commented Dec 19, 2016

Upstream issue being tracked here - ruhley/angular-color-picker#133

@sleiner
Copy link
Author

sleiner commented Dec 19, 2016

Color picking and live updates are working on Android too 👍

@dceejay
Copy link
Member

dceejay commented Dec 24, 2016

Fixed by upstream version 2.7.2 - added to package.json in 23c4422

@dceejay dceejay closed this as completed Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants