Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit option of a 'Link' added in the Dashboard 'Tab & Links' section doesn't work in v3.1.0 - it works in v3.0.1 #819

Closed
juggledad opened this issue Sep 23, 2023 · 6 comments

Comments

@juggledad
Copy link
Contributor

Current Behavior

If you open the 'Dashboard' tab in the right sidebar of the Node-red editor and select the 'Layout' tab and click the '+link' button a 'Link gets created but you can not edit it. This worked in NR v3.0.2 dashboard v3.4.0 and dashboard updated to v3.6.0 but does not work in NR v3.1.0.

The dashboard version does not matter I tested on NR v3.0.2 with dashboard v3.4.0 and it worked. I upgraded the dashboard to v3.6.0 and am not able to edit the link. It also does not work on NR v3.1.0.

Expected Behavior

Clicking the 'edit` button should let you edit the configuration

Steps To Reproduce

  • run NR v3.1.0 and open the right sidebar. Select the Dashboard tab -> Tabs & Links and click the + link button.
  • go to teh Link it creates and click on the edit button to see the issue.

Example flow

paste your flow here

Environment

  • Node-RED version: 3.1.0 node v18.12.1 and 3.0.2 node v16.20.2
  • Node.js version:
  • npm version:
  • Platform/OS: macOS and RPI
  • Browser: Safari, FireFox nad Chrome
@Steve-Mcl
Copy link
Contributor

@dceejay I suspect this needs transferring to dashboard repo - would you agree?

@dceejay
Copy link
Member

dceejay commented Sep 23, 2023

Not until we double check it's not a 3.1 issue

@dceejay dceejay transferred this issue from node-red/node-red Sep 24, 2023
@dceejay
Copy link
Member

dceejay commented Sep 24, 2023

weird, can't see why it broke, but fix pushed to master, 3.6.1

@dceejay dceejay closed this as completed Sep 24, 2023
@CodeWithGears
Copy link

I have the same Issue, please if possible let us know in this thread when the new npm will be available to fix this issue, thank you !

@juggledad
Copy link
Contributor Author

@jeremielabelle update the dashboard node to v3.6.1 and it is fixed. After updating you may need to stop/restart NR and clear your browser cache.

@CodeWithGears
Copy link

Just saw that, thank you very much it worked like a charm. Have a great day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants