Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Adding @gibfahn to help repo / perhaps give collaborators group access #58

Closed
MylesBorins opened this issue Jan 7, 2017 · 7 comments
Closed

Comments

@MylesBorins
Copy link

I'm making this issue to document manually adding @gibfahn to the help repo as a collaborator. There are two other individuals who have manually been given these permissions as well.

I would like to suggest that we give collaborator permission to @nodejs/collaborators, allowing people to opt out of notifications but maintain the ability to admin the repo.

Thoughts?

@gibfahn
Copy link
Member

gibfahn commented Jan 7, 2017

More people looking at nodejs/help seems like a good idea to me.

@jasnell
Copy link
Member

jasnell commented Feb 25, 2017

has this been done yet?

@gibfahn
Copy link
Member

gibfahn commented Feb 25, 2017

I don't think so, looking at https://github.com/orgs/nodejs/teams/collaborators/repositories

EDIT: I do now have edit access to this repo, although I can't work out how. The giving nodejs/Collaborators permissions in nodejs/help is what is outstanding.

@targos
Copy link
Member

targos commented Feb 28, 2017

The "Adding @gibfahn to help repo" part happened.
@gibfahn you have been given individual access from https://github.com/nodejs/help/settings/collaboration

I am really +1 on adding nodejs/collaborators to the allowed teams. Currently, only nodejs/evangelism is there.
Do we need a formal approval from @nodejs/ctc ?

@Trott
Copy link
Member

Trott commented Feb 28, 2017

Do we need a formal approval from @nodejs/ctc ?

Since we don't have (AFAIK) a documented process for adding people to the help repo, I'd say no, it doesn't need formal approval. But some consensus-seeking seems in order.

I'd propose:

  • tag @nodejs/ctc for comments (oh look at that, already done)
  • mention it at the CTC meeting that's happening in about 14 hours

If no one objects in either place—that is, if we only have expressions of support along perhaps with some expressions of indifference—that seems to me a reasonable indicator that we have consensus on adding nodejs/collaborators team to the nodejs/help repo.

@gibfahn
Copy link
Member

gibfahn commented Feb 28, 2017

The "Adding @gibfahn to help repo" part happened.
@gibfahn you have been given individual access from https://github.com/nodejs/help/settings/collaboration

Ahh okay, I can't see that page (I assume you have to be a nodejs org owner to see it).

@addaleax
Copy link
Member

Reading through this thread it looks like we have consensus that this is a good idea, and I don’t think there’s much harm in giving the collaborator group write access. Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants