Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Investigate FS and other codepage dependencies #25

Closed
srl295 opened this issue Oct 23, 2015 · 3 comments
Closed

Investigate FS and other codepage dependencies #25

srl295 opened this issue Oct 23, 2015 · 3 comments

Comments

@srl295
Copy link
Member

srl295 commented Oct 23, 2015

In nodejs/node#3401 it's discussed that almost all fs functions assume a Unicode-supporting filesystem, specifically, that char* are in UTF-8. While this is somewhat common (and an ideal) picture, it's not universal. Consider how to work with this issue:

  • should libuv and/or calls to it detect the encoding and convert?
    • … with a fast path for environments (OS X, Windows, others?) with a known encoding
@bnoordhuis
Copy link
Member

Libuv treats path names as byte arrays (except on Windows) so I don't think libuv is the right place to do conversion, that logic should go into the "representation layer", i.e., node.js.

with a fast path for environments (OS X, Windows, others?) with a known encoding

There is no platform-specific known encoding, it depends on the file system. Libuv probably needs to grow a statvfs(2) binding that lets node.js decide what file system it's dealing with on a per-path basis.

@srl295
Copy link
Member Author

srl295 commented Oct 27, 2015

nodejs/node#3519

@srl295
Copy link
Member Author

srl295 commented Apr 3, 2018

^ closing due to above

@srl295 srl295 closed this as completed Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants