Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What nightlies to release? #229

Closed
joaocgreis opened this issue Jun 12, 2017 · 4 comments
Closed

What nightlies to release? #229

joaocgreis opened this issue Jun 12, 2017 · 4 comments

Comments

@joaocgreis
Copy link
Member

@nodejs/lts @nodejs/build

Currently we are releasing nightlies from the master and v8.x branches (v6.x and v7.x were there until recently). While master is correct, for the LTS branches shouldn't we release nightles from the v*.x-staging branches instead?

The last nightlies for v6 seem to match the last v6 releases exactly (plus the "working on next version" commit).

Also, should we release nightlies of all LTS branches or just v8.x?

@MylesBorins
Copy link
Contributor

we could do nightlies of the the staging branches but I'm not currently convinced it is entirely necessary. We often only audit commits before a release, and at that point we are already preparing the R.C.

I for one would say that we don't need nightlies for LTS

@joaocgreis
Copy link
Member Author

Thanks, that makes sense.

@MylesBorins @jasnell what about v8.x? Should we have nothing, v8.x-staging or v8.x?

@MylesBorins
Copy link
Contributor

While 8 is in Current we should do nightlies from 8.x-staging

8.x will always be aligned with the release

@joaocgreis
Copy link
Member Author

Updated the branch in the server, next nightlies should come out of staging. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants