Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential v4.x backports #231

Closed
2 tasks
gibfahn opened this issue Jun 14, 2017 · 4 comments
Closed
2 tasks

Potential v4.x backports #231

gibfahn opened this issue Jun 14, 2017 · 4 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Jun 14, 2017

We have a couple of requested backports for v4.x, so opening this issue to track them. Please add to the list as you find them.

Things like the exitedAfterDisconnect backport may generate enough discussion that it's worth spinning out a separate issue, we can do that as it becomes necessary.

Semver-minor

  • cluster: alias suicide to exitedAfterDisconnect #7998 (Refs: #13684)

Semver-patch

  • deps: upgrade OpenSSL to version 1.0.2l #13233 (Refs: #12913 and #12691)
  • deps: cherry-pick 18ea996 from c-ares upstream #13883
@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 15, 2017

we could modify #7998 to create an alias for exitedAfterDisconnect with no warning... this would be able to land as a patch

@mhdawson
Copy link
Member

+1 on Myles suggestion for an alias.

@gibfahn
Copy link
Member Author

gibfahn commented Jun 15, 2017

we could modify #7998 to create an alias for exitedAfterDisconnect with no warning... this would be able to land as a patch

I don't understand, AFAICT #7998 doesn't have a warning, isn't this just an alias:

image

Also isn't adding an alias (i.e. a new property) semver-minor?

@MylesBorins
Copy link
Contributor

closing as v4.x is not likely to get another release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants