Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport indentation changes #239

Closed
7 tasks
MylesBorins opened this issue Aug 15, 2017 · 7 comments
Closed
7 tasks

backport indentation changes #239

MylesBorins opened this issue Aug 15, 2017 · 7 comments

Comments

@MylesBorins
Copy link
Contributor

/cc @Trott

@Trott
Copy link
Member

Trott commented Aug 15, 2017

Can I do each of these in turn, preserving metadata in the commits, but then submitting one mega-backport PR for them?

@Trott
Copy link
Member

Trott commented Aug 15, 2017

#10479 should probably happen as well and first. I'll include it in my mega-PR (if it's OK to mega-PR this).

@Trott
Copy link
Member

Trott commented Aug 15, 2017

#14417 is a no-op when applied to v6.x-staging, so it can be left out.

@Trott
Copy link
Member

Trott commented Aug 15, 2017

This also needs the ESLint updates for bug fixes.

@Trott
Copy link
Member

Trott commented Aug 15, 2017

Will need nodejs/node#13950 too.

@Trott
Copy link
Member

Trott commented Aug 15, 2017

All backported in nodejs/node#14835

@MylesBorins
Copy link
Contributor Author

Lovely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants