Remove comment regarding releasing weakrefs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
fhinkel
force-pushed
the
persistent_vs_weakref
branch
from
a723b56 to
9061e98
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
In terms of it being complete, its what we have needed so far, changes would be driven by input from porting additional modules. |
jasongin
pushed a commit
to jasongin/abi-stable-node
that referenced
this pull request
Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
JS VM Api
Description of change
I think V8 can't distinguish between
persistentandweakref, so the method to release weakrefs is needed.valueandpersistentis about lifetime, not stack vs heap, right? Ifnapi_valuecan be stored on the heap, we need to careful in V8 to handle this correctly. Is the section about "Methods to control object lifespan" pretty much in its final form?