Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment regarding releasing weakrefs #34

Merged
merged 1 commit into from
Jan 11, 2017
+0 −1
Merged

Remove comment regarding releasing weakrefs #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/node_jsvmapi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ NODE_EXTERN napi_value napi_get_persistent_value(napi_env e, napi_persistent p);
NODE_EXTERN napi_weakref napi_create_weakref(napi_env e, napi_value v);
NODE_EXTERN bool napi_get_weakref_value(napi_env e, napi_weakref w,
napi_value *pv);

This comment was marked as off-topic.

Sign in to view

// is this actually needed?
NODE_EXTERN void napi_release_weakref(napi_env e, napi_weakref w);
NODE_EXTERN napi_handle_scope napi_open_handle_scope(napi_env e);
NODE_EXTERN void napi_close_handle_scope(napi_env e, napi_handle_scope s);
Expand Down