-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Future of nodejs/examples? #883
Comments
I think it should be archived. @nodejs/tsc |
+1 for archive |
+1 for me as well. |
I’ve opened a PR against the website to remove its link to the repository, as it’s the only link (that’s not in an archived repository or changelog) to the repository. With that link removed, the repository will become an orphan, so even more of a reason to archive it. |
Shouldn't we be looking to relaunch an initiative on the repo instead of archiving it? Some lasted news about this repo nodejs/next-10#154 |
I did not have time to publish and work as much as I wanted but I booked some time in the next two weeks to finalize the plan and start bringing that up to date - and link that to the documentation / new website |
Jean, I'd be happy to give you a hand, but I don't have access to this repo. |
IMO the problem with updating it is that it'll need to contain modern examples, so it'll have to change every update. Rather than updating the repository, users can visit various GitHub sources, including Node.js itself, to see all sorts of real-world examples. |
I get what you're saying. From my perspective, the problems are:
We do not need to provide complete code for a "fake name generator". Interested parties can look at the many examples on GitHub by sindresorhus and others. We do not need to provide a complete code example of how to count entries in a directory just so that we can show people how to use We do not need to provide a complete code example for an |
I agree on point 1. "maybe shouldn't be hosted by us" I don't agree with that 100%, I think we should have some sort of "official" examples. But yes the question arises "is a repo all by itself a good idea". I think yes on one condition, if we create a team "examples/content" that has the codeowner on the learn section and the example repo. Also, there's one point on which I agree with you 200%, and that's that under no circumstances should we promote a package or make a tutorial on this page. We must restrict ourselves to node alone as a telel |
If we don't archive it (which, honestly, I still think we should), we could perhaps give the website team and/or the next-10 team access instead of individuals. (I think giving individuals access to repos is an anti-pattern and wish we would not do that. We're bad about maintaining/pruning team memberships, but we are unbelievably terrible at maintaining individual permissions on repos.) |
@ovflowd and @bmuenzenmeyer I'd like your opinion, as you're a maintainer. Personally, I also think that personal access should not be given to a repo. But on the other hand I don't think it's a good idea to give access to the team website because that's not its purpose. But if I'm sure that the work will be done because this team has a good synergy and at the moment it's still the team that does the review for the learn section even though it's outside its remit. |
I think the repository should be archived. With the redesign of the Website, I honestly believe the Learn material is enough. Maintaining up-to-date examples is tough, and I genuinely believe our API docs + Learn material should be enough. Not to mention there's hundreds of examples and content from content creators out there that dive deep on the features of Node.js, now more than ever. The repo should be archived IMO. |
I appreciate people wanting to help the community by providing official examples, but there are two things that are important to acknowledge:
If we're not archiving the repo, given the above challenges and the track record of this repo so far, I'd hope for a more robust plan then hoping that one or maybe two people volunteering get it done and do a spectacular job. Here's my possibly-unpopular suggestion: There's nothing stopping people excited about doing this from forking the repo (or starting fresh) and creating their own encyclopedic Node.js examples website or whatever. If such a thing existed and was maintained consistently, especially with the involvement of Node.js collaborators, one could propose transferring it to the nodejs org and making it official (if that's what they wanted--they could also just keep it as their own thing, which is great too). |
I therefore think that archiving the repo (mentioning that it is no longer maintained and that you should go to the learn section) is a good thing. And you can always mention an example external to the org on a page of the website (just mention that it's not "official"). As is already done here https://nodejs.org/en/learn/diagnostics/flame-graphs#examples |
That page also provides a pretty good example of why we should be very cautious and deliberate about creating more content to add to our existing documentation maintenance debt. It references Solaris VMs, "new" optimizations in Node.js 8.x, Node.js 10.x, etc. None of our current content should mention any of these things except perhaps in passing. (Admittedly, the Solaris VMs are mentioned in passing, but the entire paragraph it's in should be removed IMO.) |
As this has multiple TSC LGTMs I've gone ahead and archived nodejs/examples , note this step is reversible if we ever want to use that repository again. Thanks everyone. |
We need a concerted push to have experts update the content. Maybe we open an issue for each one, to slowly comb through them. Most were a direct port of nodejs.dev |
The repository hasn't been updated for a few years and is missing modern examples of Node.js code. If it's not actively maintained, is it still necessary?
It serves as a reference for a few links, but in my opinion, its outdated state limits its usefulness. Maybe it should be either archived or updated?
The text was updated successfully, but these errors were encountered: