-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@mmarchini request to join jenkins-admins #2209
Comments
This is why you have node-test-pull-request access, everyone on Build does. tbh I don't know why this is so permissive—who did it and why. Most jobs use the global permissions which give nodejs/jenkins-admins the permissions to configure. My preference is to keep that setup and undo this custom permission. If you want to make a case for nodejs/jenkins-admins then that's a separate process and our main concern these days is that we limit it to people who have enough clue about what they're doing that Jenkins isn't gong to get too too messed up and that we have assurance from nodejs/jenkins-admins that we get a heads-up in nodejs/build about who/what/why changes are made (like the node-test-pull-request permissions change!). Maybe for this particular instance you could just tell us what needs to be changed to get it working. |
I'm fine with that, but it's worth pinging the team before doing anything because people will lose access they have today, and might be confused by it.
Sure. On
Let's keep it as is for now. If I need access a few more times in the future I'll request to join the team. |
./configure
make -j $JOBS test-v8 V=1 $DISABLE_V8_I18N_OPTION DESTCPU=$DESTCPU ARCH=$DESTCPU.release $ADDITIONAL_CLANG_OPTIONS ENABLE_V8_TAP=True V8_EXTRA_TEST_OPTIONS="--progress=dots --timeout=120" is |
No, it's introduced in the PR I linked above to force |
ah ok, sorry!
https://ci.nodejs.org/job/node-test-commit-v8-linux/2928, looking good |
I have several permissions missing on Jenkins: I can edit configuration ofOk, I think something changed wrt how we manage access. I probably shouldn't have edit rights tonode-test-pull-request
but not any other jobs (I checkednode-test-commit-v8-linux
, a few benchmark jobs andcitgm-smoker
). I also don't have permission to create new Jobs.node-test-pull-request
.I'm trying to workaround nodejs/node#30152, so we can restore V8 test on x64 platforms, but I need to change
node-test-commit-v8-linux
configuration to do that (just need to set one environment variable before calling./configure
).I'm also planning on being more active on the WG as a whole again, and having Jenkins access would help.
The text was updated successfully, but these errors were encountered: