Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to join @nodejs/build-infra #2418

Closed
mmarchini opened this issue Aug 19, 2020 · 12 comments
Closed

Request to join @nodejs/build-infra #2418

mmarchini opened this issue Aug 19, 2020 · 12 comments

Comments

@mmarchini
Copy link
Contributor

I mentioned this on IRC and #2362 (comment), but I think we need a couple more folks on build-infra to help with incidents on the infra machines. With that in mind, I'd like to join @nodejs/build-infra to help with incidents where build-infra access is required. I'm a Netflix employee (Netflix is a OpenJS member), TSC member, OpenJS CPC regular member, and already am a Build WG member, which should cover the "trust requirement" of joining the team.

I have good time availability to deal with incidents, have experience with Linux/Unix operations (it's part of my job and has been part of previous jobs as well), and have helped with/managed incidents in our test machines in the past (#2351, #2352, #2256, #2238, #2230). When investigating issues I'm always cautious and ensure fixes won't have unwanted side effects before executing, and I prioritize open communication by updating on IRC if I'm investigating ongoing issues, and opening issues on the repo for each incident (either while working on it, or if it's an already known incident with quick fix right after it's fixed).

Let me know what you think :)

@rvagg
Copy link
Member

rvagg commented Aug 21, 2020

FYI this is being discussed (just so you know it's not being ignored), will update shortly

@rvagg
Copy link
Member

rvagg commented Aug 26, 2020

Sorry for the delay, entirely on my end as usual. We had a quick chat about this and are all 👍 but we'd like to on-board @richardlau at the same time too, who's agreed to join in the fun as well.

There's a few challenges that make this a bit tricky:

  1. On-boarding - it'd be good to have at least myself and @mhdawson together in a private Zoom to do the on-boarding, @joaocgreis and @jbergstroem too if we can wrangle it. But also including @richardlau we're almost at peak terrible-timezone-overlap. So finding a time to do it might be a challenge. Even our regular meeting time slot(s) are awkward for someone each week.

  2. Documentation & enumeration of the implicit - we've maintained a relatively small and tight group for so long that a lot of the things we do and know are more implicit than explicit. We know (mostly) how to not step on each-others toes and not because we have a well documented process. We're going to have to not only document this, but in many cases figure out what we've been doing to make it work! It's not a big deal I think, but there are some ways we can screw things up pretty bad if we go tinkering with things when it's not our place to do so or mess with things that someone else is actively working on. We also have a good sense of who "owns" what and who to defer to, so we might need to be explicit about that. I think the process of on-boarding will actually be a good chance to figure some of this stuff out so we ought to be prepared to turn it into some kind of documentation in the process.

  3. Relationship management - as an extension to point 2, we do some juggling of relationships with our various donors, and a lot of this is also not documented at all, it exists in our heads to various degrees and we know who to defer to and who to ask when things are uncertain. We need to keep our donors happy and not over-extend friendships. We have explicit limits/quotas on some services but others we have grey areas that we have to carefully navigate. e.g. on SoftLayer we don't have an explicit limit I think, but I trust @mhdawson to keep that one in check, @joaocgreis handles everything Azure, we have a Droplet quota on DO but have some flexibility on other services (like block devices) that we need to keep tight check on. None of our donors are "do what you like" and most of them need careful tending and ongoing maintenance of the relationships. It can be sensitive and it'd be good to not rock boats too much - but it would also be good to share the load of handling this too.

Let's try and get an on-boarding scheduled, but it might also be a good idea to begin a list of things such an on-boarding will need to cover. That might go into a separate issue I think.

@richardlau
Copy link
Member

@mmarchini Would you be able to make the timeslot of yesterday's Build WG meeting (#2427) but next Tuesday (15 September) for onboarding? That was the time suggested in the meeting (#2430) to get yourself, me, @mhdawson and @rvagg together on a private Zoom to do some onboarding.

@mmarchini
Copy link
Contributor Author

Yes, same time next week works for me

@mhdawson
Copy link
Member

mhdawson commented Sep 9, 2020

@richardlau can you send out an invite?

@rvagg
Copy link
Member

rvagg commented Sep 10, 2020

include @joaocgreis and @jbergstroem too, hopefully they might able to make it too as they have key pieces of the puzzle in their heads too.

@richardlau
Copy link
Member

@richardlau can you send out an invite?

Invites have been sent to @mmarchini, @mhdawson, @rvagg, @jbergstroem and @joaocgreis

@mhdawson
Copy link
Member

@richardlau can you drop and re-add me. I think I was confused when I looked at next week and deleted it.

@richardlau
Copy link
Member

@richardlau can you drop and re-add me. I think I was confused when I looked at next week and deleted it.

done

@jbergstroem
Copy link
Member

jbergstroem commented Sep 11, 2020

11pm for me but I will try to make it!

edit: nope, its not. I may be late to this one since I have overlap 😞 I will join as soon as I can and can stay overtime.

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jul 27, 2021
@mhdawson
Copy link
Member

@mmarchini is an infra admin so I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants