Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins job to test postject #3126

Closed
mhdawson opened this issue Dec 19, 2022 · 7 comments
Closed

Jenkins job to test postject #3126

mhdawson opened this issue Dec 19, 2022 · 7 comments
Labels

Comments

@mhdawson
Copy link
Member

The postject team would like a job to build/test postject.

As per - https://github.com/nodejs/build/blob/ddb05ec400ef7edf0b12dc59152ac6cd347f2a0e/GOVERNANCE.md#jenkins-job-configuration-access

We'll give the team access to start and configure the job.

I created this team - https://github.com/orgs/nodejs/teams/single-executable-admins and added @RaisinTen as the sole member.

As a TSC member I'm not concerned about the risk mentioned in https://github.com/nodejs/build/blob/ddb05ec400ef7edf0b12dc59152ac6cd347f2a0e/GOVERNANCE.md#jenkins-job-configuration-access and I trust him to manage the team members appropriately. @nodejs/build let me know if you have any concerns and I can back out the access I've given.

Working with @RaisinTen we created this job which is currently still a WIP: https://ci.nodejs.org/view/All/job/node-test-postject/ and added the single-executable-admins in the project-based security matrix so that he can modify/run the the job.

There are two issues I've come across so far:

  1. To install emsdk bzip2 is required. This only seems to be installed in a small subset of our platforms/machines. I found that it is installed on fedora34-x64
  2. To run the postject tests cmake is required this is only installed in some of our machines include the macOS machines. It is unfortunately not installed on fedora34-x64.

@RaisinTen I think you mentioned there was a problem on Macos? If not they I might try to see if the job runs passes there.

@nodejs/build we'll need to decided if we can install bzip2 and cmake across the ci machines to be able to support this teat job.

@RaisinTen
Copy link
Contributor

RaisinTen commented Dec 20, 2022

Thanks Michael!

@RaisinTen I think you mentioned there was a problem on Macos? If not they I might try to see if the job runs passes there.

I was referring to nodejs/postject#68 and it's been fixed already.

@tony-go
Copy link
Member

tony-go commented Dec 23, 2022

Awesome 🎉

@mhdawson
Copy link
Member Author

mhdawson commented Jan 9, 2023

@nodejs/build we still need discussion to decide if we can install bzip2 and cmake across the ci machines to be able to support this test job.

@richardlau
Copy link
Member

No opinion on bzip2 but cmake was something we were rolling out across the CI, for both CITGM and libuv.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 9, 2023

The license for bzip2 seems to be BSD like. As long as we can install from the native package managers I think it makes sense to just plan to install it like we were for cmake

@RaisinTen
Copy link
Contributor

Would it also be possible to install Ninja?
This macOS build - https://ci.nodejs.org/view/All/job/node-test-postject/10/nodes=osx1015/console is failing with:

CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.

Copy link

github-actions bot commented Nov 7, 2023

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Nov 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants